Page 20 of 21 FirstFirst ... 1018192021 LastLast
Results 191 to 200 of 206

Thread: Official ;tpick changes and discussion

  1. #191

    Default

    Quote Originally Posted by Tgo01 View Post
    Pretty sure I have this bug fixed in the latest version.
    Awesome, thanks Tgo! Your work is amazeballs.

  2. #192

    Default

    Uploaded a new version of ;tpick which has a new setting to use LMASTER FOCUS if you want.

    If you don't have a version of Lich or spell-data.xml which can detect when "Focused" is active you will need to add the following lines to your spell-data.xml file:

    Code:
    <spell availability='self-cast' name='Focused' number='2001' type='utility'>
          <duration span='refreshable' max='2'>2</duration>
          <message type='start'>You focus intently on your picking and disarm skill.</message>
          <message type='end'>You no longer appear focused.</message>
       </spell>
    Last edited by Tgo01; 07-27-2021 at 09:13 AM.

  3. Default

    Quote Originally Posted by Tgo01 View Post
    Uploaded a new version of ;tpick which has a new setting to use LMASTER FOCUS if you want.

    If you don't have a version of Lich or spell-data.xml which can detect when "Focused" is active you will need to add the following lines to your spell-data.xml file:

    Code:
    <spell availability='self-cast' name='Focused' number='2001' type='utility'>
          <duration span='refreshable' max='2'>2</duration>
          <message type='start'>You focus intently on your picking and disarm skill.</message>
          <message type='end'>You no longer appear focused.</message>
       </spell>
    So I notice if you find no trap but have detect for trap, then it checks the lock, it SAYS: 403 Recommended: No, but then it just leaves focus running. So probably need a stop focus in that particular instance. If it's up and you don't need 403 that is...

  4. #194

    Default

    Quote Originally Posted by lorddemandred View Post
    So I notice if you find no trap but have detect for trap, then it checks the lock, it SAYS: 403 Recommended: No, but then it just leaves focus running. So probably need a stop focus in that particular instance. If it's up and you don't need 403 that is...
    The script (should) still use settings for 403 and 404 for when you want Focused stopped. For example if you have it so 403 is stopped before each box and whatnot the script should be stopping "Focused" in those instances. If not then the script will leave 403/Focused running.

  5. Default

    Quote Originally Posted by Tgo01 View Post
    The script (should) still use settings for 403 and 404 for when you want Focused stopped. For example if you have it so 403 is stopped before each box and whatnot the script should be stopping "Focused" in those instances. If not then the script will leave 403/Focused running.
    Right, it does this. But... if you have it set to detect, and it does not find a trap, it doesn't stop lmaster focus. So then when it finds the lock, with it set to stop 403 every time, it has no reason right now to look to see if focused is on because before they were separate, but focus is running because you turned it BACK on to look for a trap... Hang on lemme get a log of a picking session and show you... it turns it off and on a lot now.

  6. Default

    [tpick]>lmaster focus
    You focus intently on your picking and disarm skill.
    Roundtime: 3 sec.
    JR>
    JR>
    [tpick]>detect #8633774
    You carefully begin to examine a scratched iron strongbox for traps...

    Peering closely into the lock, you spy a glimmering opalescent scarab wedged into the lock mechanism. The scarab's surface is etched with tiny runes that seem to writhe as the light strikes them.


    It looks like a difficult trap (about -159).

    You still have a good enough picture of the trap in your mind, that you could try to disarm it.
    Roundtime: 4 sec.
    JR>
    [tpick]>say :terse =comment Scarab on this one.
    [tpick: Trap difficulty is: 159]
    [tpick: Your disarm skill is: 236]
    [tpick: Your total disarm skill with lore is: 379]
    [tpick: Highest trap you are willing to try is: 359]
    [tpick: Found a scarab trap.]
    You tersely comment, "Scarab on this one."
    JR>
    [tpick: Attempting to disarm trap.]
    [tpick]>disarm #8633774
    Having discovered a trap on the strongbox you begin to carefully attempt to disarm it...

    You feel like you've made a talented attempt (d100=86).

    You carefully nudge the scarab free of its prison without disturbing the lock too much. The scarab falls from the lock and onto the ground in front of you.

    Roundtime: 6 sec.
    JR>
    [tpick]>say :grave =inform Live scarab on the ground.
    You gravely inform, "Live scarab on the ground."
    JR>
    [tpick: Scarab trap has been disarmed.]
    JR>
    [tpick: Disarming scarab.]
    [tpick]>disarm #8671533
    You carefully begin to examine the scarab for traps...

    Knowing how delicate magical runes can be, you carefully scrape a few extra lines into the markings, hoping to alter their meaning and defeat the spell they may hold.

    *scritch scritch* If that had been any easier, you could have done it blindfolded.
    J>
    [tpick]>get #8671533
    You pick up a glimmering opalescent scarab.
    J>
    [tpick]>say :calm =assert Scarab up.
    You calmly assert, "Scarab up."
    J>
    [tpick]>put #8671533 in my pouch
    J>
    You put a glimmering opalescent scarab in your black linen pouch.
    J>
    [tpick: Measuring lock.]
    [tpick]>get my calipers
    You remove a set of sleek imflass-tipped calipers from in your grain leather kit.
    J>
    [tpick]>lmaster measure #8633774
    Using your imflass-tipped calipers, you carefully begin to measure the lock...
    Roundtime: 3 sec.
    JR>
    JR>
    Measuring carefully, it looks to be a fairly plain lock (-370 in thief-lingo difficulty ranking).
    JR>
    [tpick: You have lock buffer set to 0, going to assume this lock is +0 higher at -370]
    [tpick]>put #7578542 in #7578541
    You put a set of sleek imflass-tipped calipers in your grain leather kit.
    J>
    [tpick: Recommended lock pick: rolaren with a modifier of 1.9]
    [tpick: Recommend 403: No]
    [tpick: Your calculated lockpicking skill: 236]
    [tpick: Your total picking skill for this attempt is: 448]
    [tpick: Lock difficulty: 370]
    [tpick]>get #7578510
    You detach an opal-edged grey rolaren lockpick from a vaalin-laced keyring.
    J>
    [tpick: Attempting to pick lock.]
    [tpick]>lmas ptrick twirl #8633774
    With a casual motion, you twirl your grey rolaren lockpick around your index finger, catching it between thumb and forefinger before applying it to the lock of a scratched iron strongbox...
    You make an excellent attempt (d100=90).
    You struggle with the strongbox. As you do, you get a sense that the strongbox has a fairly plain lock (-370 thief-lingo difficulty ranking). Then...CLICK! It opens!
    J>
    [tpick]>put #7578510 in #7578482
    You attach an opal-edged grey rolaren lockpick to a vaalin-laced keyring.
    J>
    J>
    [tpick: Number of locks successfully opened since last broken lockpick: laje: 444, copper: 971, veniom: 648, invar: 538, mithril: 1214, rolaren: 504, silver: 413, vultite: 128, gold: 479, ora: 368, vaalin: 156, steel: 846, golvern: 333, alum: 363, glaes: 404, kelyn: 75. Number of total locks picked since any lockpick broke: 3026]

    ####################
    ####################
    Total boxes picked: 22861
    Total time picking: 518960.1 seconds
    Average time per box: 22.7 seconds
    ####################
    ####################


    ####################
    ####################
    Boxes remaining: 15
    Estimated time remaining: 340.5 seconds
    ####################
    ####################

    [tpick]>open #8633774
    You open a scratched iron strongbox.
    J>
    [tpick]>look in #8633774
    J>
    In the iron strongbox:
    Gems [2]: a piece of red jasper, a yellow sapphire
    Special [1]: some silver coins
    Total items: 3
    J>
    [tpick]>get #8633777
    J>
    You remove a piece of red jasper from in a scratched iron strongbox.
    J>
    [tpick]>put #8633777 in my pouch
    You put a piece of red jasper in your black linen pouch.
    J>
    [tpick]>get #8633776
    You remove a yellow sapphire from in a scratched iron strongbox.
    J>
    [tpick]>put #8633776 in my pouch
    You put a yellow sapphire in your black linen pouch.
    J>
    [tpick]>get #8633775
    J>
    You gather the remaining 4,063 coins.
    Roundtime: 3 sec.
    JR>
    [tpick]>clean table
    A busboy appears at your bidding and gathers up debris from your table.
    J>
    [tpick]>stop lmaster focus
    You no longer appear focused.
    J>
    [tpick: Checking for traps.]
    [tpick]>lmaster focus
    J>
    You focus intently on your picking and disarm skill.
    Roundtime: 3 sec.
    JR>
    [tpick]>detect #8638904
    ...wait 1 seconds.
    JR>
    Timestamp: 10:56:24 07-27-2021
    JR>
    [tpick]>detect #8638904
    You carefully begin to examine an acid-pitted iron strongbox for traps...

    You discover no traps.
    Roundtime: 5 sec.
    JR>
    [tpick: No trap found.]
    JR>
    [tpick: Measuring lock.]
    [tpick]>get my calipers
    You remove a set of sleek imflass-tipped calipers from in your grain leather kit.
    J>
    [tpick]>lmaster measure #8638904
    Using your imflass-tipped calipers, you carefully begin to measure the lock...
    Roundtime: 4 sec.
    JR>
    JR>
    JR>
    JR>
    JR>
    JR>
    JR>
    JR>
    JR>
    Measuring carefully, it looks to be a fairly simple lock (-345 in thief-lingo difficulty ranking).
    J>
    [tpick: You have lock buffer set to 0, going to assume this lock is +0 higher at -345]
    [tpick]>put #7578542 in #7578541
    You put a set of sleek imflass-tipped calipers in your grain leather kit.
    J>
    [tpick: Recommended lock pick: laje with a modifier of 1.75]
    [tpick: Recommend 403: No]
    [tpick: Your calculated lockpicking skill: 236]
    [tpick: Your total picking skill for this attempt is: 413]
    [tpick: Lock difficulty: 345]
    [tpick]>get #7578483
    You detach a laje lockpick from a vaalin-laced keyring.
    J>
    [tpick: Attempting to pick lock.]
    [tpick]>lmas ptrick flip #8638904
    Pretending to only examine the lock of an acid-pitted iron strongbox, you instead attempt to quietly turn the tumblers to within a hair's breadth of clicking...
    You make a poor attempt (d100=34).
    You get a sense that the strongbox has a fairly simple lock (-345 thief-lingo difficulty ranking).

    Then with an easy motion, you flip your lockpick into the air and give the strongbox a solid smack!

    The strongbox gives off an audible *click* as the tumblers snap open.
    J>
    [tpick]>put #7578483 in #7578482
    You attach a laje lockpick to a vaalin-laced keyring.
    J>
    [tpick: Number of locks successfully opened since last broken lockpick: laje: 445, copper: 971, veniom: 648, invar: 538, mithril: 1214, rolaren: 504, silver: 413, vultite: 128, gold: 479, ora: 368, vaalin: 156, steel: 846, golvern: 333, alum: 363, glaes: 404, kelyn: 75. Number of total locks picked since any lockpick broke: 3027]

    ####################
    ####################
    Total boxes picked: 22862
    Total time picking: 518977.23 seconds
    Average time per box: 22.7 seconds
    ####################
    ####################


    ####################
    ####################
    Boxes remaining: 14
    Estimated time remaining: 317.8 seconds
    ####################
    ####################

    [tpick]>open #8638904
    You open an acid-pitted iron strongbox.
    J>
    [tpick]>look in #8638904
    J>
    In the iron strongbox:
    Special [1]: some silver coins
    Total items: 1
    J>
    [tpick]>get #8638905
    You gather the remaining 1,954 coins.
    Roundtime: 2 sec.
    JR>
    [tpick]>clean table
    J>
    [tpick]>stop lmaster focus
    A busboy appears at your bidding and gathers up debris from your table.
    J>
    [tpick: Checking for traps.]
    You no longer appear focused.
    J>
    [tpick]>lmaster focus
    You focus intently on your picking and disarm skill.
    Roundtime: 3 sec.
    JR>
    [tpick]>detect #8630138
    You carefully begin to examine a simple maoral box for traps...

    Looking closely into the keyhole of the lock, you spy a small, dark crystal which seems imbedded in the locking mechanism. It looks as if opening the lock without the exact key could shatter it.

    It looks like a simple trap (-71).

    You still have a good enough picture of the trap in your mind, that you could try to disarm it.
    Roundtime: 3 sec.
    JR>
    [tpick: Trap difficulty is: 71]
    [tpick: Your disarm skill is: 236]
    [tpick: Your total disarm skill with lore is: 379]
    [tpick: Highest trap you are willing to try is: 359]
    [tpick: Found a crystal trap.]
    J>
    **** 34 EXP Gained this Pulse **** (10:56:49)
    J>
    [tpick: Attempting to disarm trap.]
    [tpick: According to your settings you want to stop 404 when it's not needed to disarm a trap.]
    [tpick]>stop lmaster focus
    You no longer appear focused.
    J>
    [tpick]>disarm #8630138
    J>
    Having discovered a trap on the box you begin to carefully attempt to disarm it...

    You feel like you've made a lame attempt (d100=28).

    With a little ingenuity you manage to grind down parts of the lock mechanism with your metal file, so it won't come in contact with the crystal when you try to open it.
    Roundtime: 5 sec.
    JR>
    [tpick: Crystal trap has been disarmed.]
    JR>
    JR>
    JR>
    JR>
    JR>
    [tpick: Measuring lock.]
    [tpick]>get my calipers
    You remove a set of sleek imflass-tipped calipers from in your grain leather kit.
    J>
    [tpick]>lmaster measure #8630138
    Using your imflass-tipped calipers, you carefully begin to measure the lock...
    Roundtime: 5 sec.
    JR>
    JR>
    Measuring carefully, it looks to be a simple lock (-290 in thief-lingo difficulty ranking).
    JR>
    JR>
    JR>
    JR>
    [tpick: You have lock buffer set to 0, going to assume this lock is +0 higher at -290]
    [tpick]>put #7578542 in #7578541
    J>
    You put a set of sleek imflass-tipped calipers in your grain leather kit.
    J>
    [tpick: Recommended lock pick: ora with a modifier of 1.55]
    [tpick: Recommend 403: No]
    [tpick: Your calculated lockpicking skill: 236]
    [tpick: Your total picking skill for this attempt is: 365]
    [tpick: Lock difficulty: 290]
    [tpick]>get #7578496
    You detach an opalescent ora lockpick from a vaalin-laced keyring.
    J>
    [tpick: Attempting to pick lock.]
    [tpick]>lmas ptrick twist #8630138
    You give your ora lockpick a sharp twist, attempting to straighten it slightly, before settling into the difficult task of picking the lock on a simple maoral box...
    You make a passable attempt (d100=41).
    You struggle with the box. As you do, you get a sense that the box has a simple lock (-290 thief-lingo difficulty ranking). Then...CLICK! It opens!
    Roundtime: 5 sec.
    JR>
    Last edited by lorddemandred; 07-27-2021 at 12:03 PM.

  7. Default

    So in the log I posted above, I bolded all the lmaster focus starts/stops - you can see where because it didn't stop it after the trap (no trap so no reason to stop), it left it on when it picked the lock (despite it reporting that it did not recommend using lore(403) for the lock)

    It ends up being a substantial decrease in exp per box whenever it's on, I was watching earlier this morning...

    edit: bear in mind I have fixed this in mine, just wanted to put it out there that it's happening.

    Code:
    def focus_check
    	if Effects::Buffs.to_h.include?("Focused")
    		focus_ends = Effects::Buffs.to_h["Focused"] - Time.now
    		if focus_ends > 0
    			return focus_ends
    		else
    			return 0
    		end
    	else
    		return 0
    	end
    end
    Then right after the section in pick3 proc:
    Code:
    pick3 = proc{
    	next_task = nil
    	roll_amount = nil
    	if (open_plinites) || current_box.name =~ /plinite/
    		echo "Attempting to extract plinite."
    	else
    		echo "Attempting to pick lock." if UserVars.tpick["run_silently"] !~ /yes/i
    	end
    	waitrt?
    	tpick_cast_spells (1035) if use_spell_1035
    	unless UserVars.tpick["always_use_403"] == "never"
    		(tpick_cast_spells (403)) if (need_403 == "yes" || use_spell_403)
    	end
    	if focus_check > 0 && !need_403 && !use_spell_403 && !i_need_403
    		fput "stop lmaster focus"
    	end
    	if (open_plinites) || current_box.name =~ /plinite/
    		fput "extract ##{current_box.id}"
    	elsif gnomish_bracers && override_bracers != "override"
    		tpick_get_box(current_box) if solo_or_other == "ground"
    		fput "push my #{gnomish_bracers}"
    	else
    You can see my focus_check there . . . I also pushed that check in wherever you were checking for it. Let's it work without spell-list.xml.

    woops, final edit: although it does require being on the newer lich with the Effects container populating... O.o
    Last edited by lorddemandred; 07-27-2021 at 01:35 PM.

  8. #198

    Default

    Uploaded a new version that should fix all of this:

    Version 363: New option for both "Lock Pick Enhancement (403)" and "Disarm Enhancement (404)". You can now enter "auto" for either of these options and the script will cast 403/404 when they are needed and stop the spells before picking/disarming if they aren't needed.
    Version 363: You can combine these options by separating each command with a space or comma, for example you can do: auto 100 detect - and all three options will be enabled.

    So if you have the following for 404:

    auto 100 detect

    It would automatically cast 404 if the script determines it's necessary, OR if the trap difficulty is greater than 100. Also it would use 404 before DETECTING boxes. Finally with the "auto" option it would automatically stop 404 before DISARMing if the script determines 404 isn't necessary to disarm the box (because the trap difficulty is lower than 100 and the script determines it isn't necessary.)

    This way you can eliminate using the "cancel" option if you want (which cancels 403/404 before each box) since with "auto" it only stops the spells if the script determines they aren't necessary.

    This should cut down on the number of times the script starts/stops 403/404/Focused if you don't just keep them up all the time like I do
    Last edited by Tgo01; 07-27-2021 at 02:04 PM.

  9. Default

    Quote Originally Posted by Tgo01 View Post
    This should cut down on the number of times the script starts/stops 403/404/Focused if you don't just keep them up all the time like I do


    I pick for exp some still, so stopping the spells/focus is still nice. Thanks for updating!

  10. Default

    First off still a great job on this script! I love using it!

    I think I found a bug. When using the script on the locksmith pool frequently the script would stop right after requesting a job.

    It looks like at some point commas were added to the tip value, so anytime the tip is more than 999 it would just wait.

    I was able to fix it in my local copy by updating both of the offered_tip_amount regex as well as the to_i calls, in start_worker.

    I used ([0-9\,]+) for the regex and $1.tap { |s| s.delete!(',') }.to_i for the conversion.

    Thanks!
    Illithek
    Illithek

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •