Page 3 of 3 FirstFirst 123
Results 21 to 30 of 30

Thread: Sbounty: Bug Fix List

  1. #21

    Default

    I've applied most the changes in that 2017 version with a few exceptions. I'm testing everything out locally and then I'll upload it. Urchin guide stuff is new since I played last. I'll take a look.
    It must be hard to type with ghostcrawlers penis lodged in your ass. - g++

  2. #22
    Join Date
    May 2010
    Location
    With your mom
    Posts
    1,672

    Default

    Quote Originally Posted by SpiffyJr View Post
    I've applied most the changes in that 2017 version with a few exceptions. I'm testing everything out locally and then I'll upload it. Urchin guide stuff is new since I played last. I'll take a look.
    Are you not monking? I don't see Paix.

    WHY U NO MONK?

  3. #23

    Default

    I'm kips'ing! Halfling warrior is like a halfling monk except I have guild skills and better cmans. Oh, and armor. And guard and protect.
    It must be hard to type with ghostcrawlers penis lodged in your ass. - g++

  4. #24

    Default

    Issue: Removes a completed bounty instead of turning it in.

    FIX:
    Code:
    while true
        talk_to_npc.call
    
        if can_do_bounty.call and not CharSettings[:should_rest_wounded].call
            if is_bounty.call 'task_search'
                task_search.call
            elsif is_bounty.call 'task_forage' and Time.now.to_i >= last_forage_attempt + last_forage_delay
                task_forage.call
            end
        elsif Spell['Next Bounty'].active? and (expedite_left and not is_bounty.call 'none' and not can_do_bounty.call and CharSettings[:enable_expedite])
            expedite_bounty.call
            next
        end
    
        if is_bounty.call 'task_escort' and GameObj.npcs.find { |npc| npc.name =~ /child/ }
            task_escort.call 'advguard'
        elsif is_bounty.call 'task_fail'
            can_do_bounty_cache = nil
        elsif is_bounty.call 'success_heirloom'
            success_heirloom.call
        end
    
        exit if dead?
    
        if can_turn_in.call
            turn_in.call
            resting = false
        else
            if not can_do_bounty.call and not Spell['Next Bounty'].active?
    			#ADDED-START
                remove_bounty.call unless is_bounty.call ['success']
    			#ADDED-END
    Last edited by SashaFierce; 07-13-2017 at 03:07 AM.

  5. #25

    Default

    Applied that Sasha (but I applied it to the line above).

    Code:
    if not can_do_bounty.call and not Spell['Next Bounty'].active? and not is_bounty.call ['success']
    It must be hard to type with ghostcrawlers penis lodged in your ass. - g++

  6. #26

    Default

    Still testing out this update. I'll be pushing it end of day probably.
    It must be hard to type with ghostcrawlers penis lodged in your ass. - g++

  7. #27

    Default

    Issue: sbounty will forage in rooms with other players.

    Fix:

    Code:
    task_forage = proc {
        ...
        while get_herb_count.call < count and not CharSettings[:should_rest_wounded].call and num_tries < 3
            ...
            while get_herb_count.call < count and rooms.length > 0 and not CharSettings[:should_rest_wounded].call
                if !kneeling? and GameObj.pcs.any?
                    break
                end
    "..." meaning other code in between, but not relevant for the fix. The kneeling check is there so the script doesn't care if players walk into the room after you've already started foraging. I haven't actually tested this yet, but unless GameObj.pcs doesn't work as documented, it should be fine.
    Last edited by Zenith; 07-13-2017 at 12:30 PM.

  8. #28

    Default

    Applied that. It should work as intended.
    It must be hard to type with ghostcrawlers penis lodged in your ass. - g++

  9. Default

    In case the not turning in heirloom is still not fixed for all locations - here's Zul Logoth:

    You have been tasked to recover a beryl-inset twisted copper torc that an unfortunate citizen lost after being attacked by a troll wraith in the Troll Burial Grounds near Zul Logoth. The heirloom can be identified by the initials JD engraved upon it. Hunt down the creature and LOOT the item from its corpse.

    You spy a beryl-inset twisted copper torc, which looks like the heirloom that you are searching for!


    The guard says, "Ah, so you're from the Adventurer's Guild? Yes, we do have a task for you. One of our citizens was attacked by a troll wraith in the Troll Burial Grounds near Zul Logoth. She barely escaped with her life. Unfortunately, in her haste to escape, she dropped a family heirloom of great sentimental value to her. She has put up a reward for its safe return. The heirloom is a braided silver necklace and you'll be able to identify it by the initials GF engraved upon it. Hunt down the creature that attacked her, retrieve the heirloom, and report back to me."

    You spy a braided silver necklace, which looks like the heirloom that you are searching for!

    You have located a pair of asterfire earrings and should bring it back to one of the Zul Logoth tunnel guards.


    I also occasionally have a problem where it doesn't pick up the searched heirloom, not sure why:

    You are already kneeling.
    You intently search the area for the heirloom, sifting through the rocks and stones.
    You spy a pair of asterfire earrings, which looks like the heirloom that you are searching for!
    Roundtime: 10 sec.
    An undertaker bat wafts in.

    [sbounty]>gird

    You remove a spiraled orase runestaff capped with a glowing quartz orb from in your spidersilk cloak.

    [sbounty]>stand

    You stand back up.

    --- Lich: 'spellactive' has been stopped by sbounty.

    [sbounty: -- turning in heirloom]


    Hope this is useful

  10. #30

    Default

    Spiffy,

    Can you also update sloot's reporting (checksilvers) to work with prettynum?

    Change:
    Code:
    if server_string !~ /^\s*Mana\:\s+\-?[0-9]+\s+Silver\:\s+([0-9]+)/
        nil
    elsif server_string =~ /^\s*Mana\:\s+\-?[0-9]+\s+Silver\:\s+([0-9]+)/
        silvers = $1.to_i
    To:

    Code:
    if server_string !~ /^\s*Mana\:\s+\-?[0-9\,]+\s+Silver\:\s+([0-9\,]+)/
        nil
    elsif server_string =~ /^\s*Mana\:\s+\-?[0-9\,]+\s+Silver\:\s+([0-9\,]+)/
        silvers = $1.delete(',').to_i

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •