;tpick is ignoring silver boxes

[Methais]

Seems to have started at around the same time as ;useherbs started acting stupid about not depositing my coins http://forum.gsplayers.com/showthread.php?125112-useherbs-won-t-deposit-my-silvers-anymore

Checked with Dreaven and he's not sure what it would be either. The items are still registering as boxes, ;tpick is just ignoring them.


box (2): a scratched silver chest, a scratched silver trunk.


>get che from my viridian robe
You remove a scratched silver chest from in your viridian ritual robe.

>;eq echo "#{GameObj.right_hand.type}"
[exec1: box]

put che in my robe
You put a scratched silver chest in your viridian ritual robe.

>get tru from my viridian robe
>
You remove a scratched silver trunk from in your viridian ritual robe.

>;eq echo "#{GameObj.right_hand.type}"
[exec1: box]


When running ;tpick:

;tpick v
--- Lich: tpick active.
That is already open.
>That is already open.
>
--- Lich: 'sorter' has been stopped by tpick.
--- Lich: sorter has exited.
>
[tpick: Putty remaining: 18]
[tpick: Cotton balls remaining: 33]
[tpick: Vials of acid remaining: 0]
--- Lich: sorter active.
>


>

####################
####################
Total boxes picked: 9950
Total time picking: 78630.71 seconds
Average time per box: 7.9 seconds
####################
####################


####################
####################
Boxes remaining: 0
Estimated time remaining: 0.0 seconds
####################
####################

>
Total boxes picked: 0
Total silvers gained: 0
--- Lich: tpick has exited.
look in my cloak
>In the diamond-clasped cloak:
box (1): a battered silver box.
uncommon,lockpick (3): a vaalin lockpick (3).


I haven't changed any settings on anything lately. Tried re-downloading gameobj-data.xml, didn't work either, and I have no idea what else to check that could be thrown off.

Halp.

[Methais]

Another thing I just noticed when picking up silver boxes that I'm not getting with non-silver boxes, which looks more like an ;sloot thing or some other script, but I'm fairly sure ;sloot isn't used as part of ;tpick.

Plus I'm not picking these boxes with Methais, I'm using my rogue. Anyway:

You search the lost soul.
You discard the soul's useless equipment.
He carried a sturdy silver chest on him!
A lost soul fades into oblivion.
>
You pick up a sturdy silver chest.
>
Your chest won't fit in the clam-shaped Methais disk.
>
Your chest won't fit in the black silk bag.
>
You put a sturdy silver chest in your viridian ritual robe.
>
Get what?
>

[sloot: failed to get item "sturdy silver chest" from "fitted viridian ritual robe"]

[Risen]

;la

You have probably checked, but I wonder if another script is causing it. Might do a ;version and post as well, maybe.

[Methais]

;la

You have probably checked, but I wonder if another script is causing it. Might do a ;version and post as well, maybe.


>;la
--- Lich: rnum, whatlevel, killcounter, keepalive, percentcapped, disarmed, commas, xnarost, lnet, sexual-favors, no-speech-window, autovote, infomon



;version
--- Lich: version active.
```
Ruby version........: 2.5.5
Ruby platform.......: i386-mingw32
Ruby engine.........: ruby
Lich version........: 4.6.54
SQLite3 version.....: 1.4.0
Gtk version.........: 2.24.30
Cairo version.......: 1.16.0
;version Version....: 0.5

LICH_DIR............: D:/SIMU/lich
SCRIPT_DIR..........: D:/SIMU/lich/scripts
DATA_DIR............: D:/SIMU/lich/data
TEMP_DIR............: D:/SIMU/lich/temp
LOG_DIR.............: D:/SIMU/lich/logs
MAP_DIR.............: D:/SIMU/lich/maps
BACKUP_DIR..........: D:/SIMU/lich/backup
Ruby location.......: C:\Ruby4Lich\bin\rubyw.exe

MapDB filename................: map-1584408803.dat
MapDB last modified...........: 2020-03-23 11:04:29 -0500
gameobj-data last modified....: 2020-06-19 07:42:46 -0500
spell-list last modified......: 2016-01-20 16:50:24 -0600

Running scripts.....: lnet, sexual-favors, rnum, whatlevel, no-speech-window, killcounter, keepalive, autovote, percentcapped, disarmed, commas, infomon, xnarost, version
Downstream hooks....: lnet-watch-forage, rNums, whatlevel, prettybounty, no-speech-window, commas, SLootDisk, SLootGameObjWatcher, fix_gameobj_status
Upstream hooks......: lnet, sexual-favors, killtracker, alias-service, infomon
Current threads.....: 26
```
Use `;version SCRIPT [SCRIPT2 [SCRIPT3...]]` to report the installed versions of one or more Lich scripts.
Use `;version ALL` to report the installed versions of ALL downloaded Lich scripts.
--- Lich: version has exited.





And on the rogue...

>;la
--- Lich: keepalive, rnum, commas, infomon, lnet, no-speech-window, sorter

[Methais]

It was ;commas causing it.

No clue how, but I'm assuming that's what's fucking with ;useherbs too. I noticed earlier the amount of coins it deposits is whatever I have on me before the first comma, i.e. if I had 7,000 coins on me, it'll deposit 7. If I had 14,000, it deposits 14 coins. And I started using that script about a week ago, so it adds up.

God dammit. I liked that script. :(

[Risen]

You can try this modification until Ondreian sees this and makes a better change.




if server_string =~ NOT_SPELLS && server_string !~ /box|chest|coffer|strongbox|trunk/ then


I do not think it will help with the deposit silver issue.

[m444w]

Hey there I just created an issue https://github.com/elanthia-online/scripts/issues/256 around this bug, I will fix it as soon as possible and see about testing against tpick and useherbs to verify.

[m444w]

I think I fixed both issues, it should no longer mess with `id=""` in the XML and will not mutate strings when `useherbs` is active, unfortunately useherbs grabs the silvers after all DownstreamHooks run, so it will be borked unless I special-case it.

Also should have fixed the point-and-click functionality of the SHOP BROWSE commands, and slightly improved performance.

Please verify for me if you get a chance, I don't use either tpick or useherbs, but I tried to test them out as best as I could.

[Methais]

I think I fixed both issues, it should no longer mess with `id=""` in the XML and will not mutate strings when `useherbs` is active, unfortunately useherbs grabs the silvers after all DownstreamHooks run, so it will be borked unless I special-case it.

Also should have fixed the point-and-click functionality of the SHOP BROWSE commands, and slightly improved performance.

Please verify for me if you get a chance, I don't use either tpick or useherbs, but I tried to test them out as best as I could.

I’ll check it out next time I’m on and let you know what happens. Thanks for the quick fix.

[Methais]

I think I fixed both issues, it should no longer mess with `id=""` in the XML and will not mutate strings when `useherbs` is active, unfortunately useherbs grabs the silvers after all DownstreamHooks run, so it will be borked unless I special-case it.

Also should have fixed the point-and-click functionality of the SHOP BROWSE commands, and slightly improved performance.

Please verify for me if you get a chance, I don't use either tpick or useherbs, but I tried to test them out as best as I could.

It's fixed with ;useherbs, but still skipping silver boxes with ;tpick.

[m444w]

It's fixed with ;useherbs, but still skipping silver boxes with ;tpick.

I just deployed a more brute force fix for commas so it won't try to parse anything while tpick is running for now using the same return early pattern as useherbs so you're not left in the lurch until I figure out why it's ignoring silver boxes. I didn't get a single silver box this morning when I was hunting to test with. :(

[Methais]

I just deployed a more brute force fix for commas so it won't try to parse anything while tpick is running for now using the same return early pattern as useherbs so you're not left in the lurch until I figure out why it's ignoring silver boxes. I didn't get a single silver box this morning when I was hunting to test with. :(

I'll have some soon enough. I'll post results when I get to test it.