View Full Version : Go2 Map Database Woes
Ifor Get
05-17-2017, 04:17 PM
I know most of you don't give a crap about Shattered, but we write some pretty damn awesome scripts. To that end, we have a serious crossover problems for scripts that utilize the map database. Presently the go2 room numbers for Prime and Shattered do not match up. Is there any way to take the existing Prime map database and just overwrite the content of the Shattered map database so that everything matches up? The worlds are the same, the maps are the same, but a lot of things are broken or not even properly mapped in Shattered.
We have tried uploading changes, but they always get overwritten when we log back in and nothing new has been pushed down in quite a while.
horibu
05-17-2017, 06:29 PM
So you can't checkout mapdb and then overwrite/upload Prime's map database? Or you have but something keeps reverting it?
Sent from my VS985 4G using Tapatalk
Tillmen
05-17-2017, 10:54 PM
... we have a serious crossover problems for scripts that utilize the map database. Presently the go2 room numbers for Prime and Shattered do not match up.
Any script that is using room numbers is probably doing it wrong. Rooms can have tags so that room numbers aren't needed and scripts can work in all three map databases.
Is there any way to take the existing Prime map database and just overwrite the content of the Shattered map database so that everything matches up?
Yes.
The worlds are the same, the maps are the same ...
No they're not. Someone in Platinum had the same idea. Prime map looks more complete and correct, so just copy it over and then fix all the little differences. I think you're both underestimating just how many differences there are between the game instances, and how much time and effort it would take to find them all, let alone fix them all. But if you're willing to put in the effort to make it all correct, go for it.
... but a lot of things are broken or not even properly mapped in Shattered.
You should totally fix them.
We have tried uploading changes, but they always get overwritten when we log back in and nothing new has been pushed down in quite a while.
Server logs show only two attempts to upload the Shattered map database this year, but neither of them were preceded by a ";repo checkout-mapdb". This likely resulted in the repository script saying something like "[repository: error: server says: not authorized]" and no actual upload to the server. Just do ";repo checkout-mapdb" before you start making changes, and then upload-mapdb should work.
Ifor Get
05-19-2017, 06:14 PM
So you can't checkout mapdb and then overwrite/upload Prime's map database? Or you have but something keeps reverting it?
Sent from my VS985 4G using Tapatalk
It keeps reverting, apparently.
Server logs show only two attempts to upload the Shattered map database this year, but neither of them were preceded by a ";repo checkout-mapdb". This likely resulted in the repository script saying something like "[repository: error: server says: not authorized]" and no actual upload to the server. Just do ";repo checkout-mapdb" before you start making changes, and then upload-mapdb should work.
I'll pass this along to Casis, he is the one who has been heading up this effort.
Ifor Get
05-19-2017, 06:28 PM
Any script that is using room numbers is probably doing it wrong. Rooms can have tags so that room numbers aren't needed and scripts can work in all three map databases.
This assumes there are existing tags that can be used as a unique identifier for said room. For a lot of these places the map database is wrong or incomplete, therefore room numbers must be used. So, we are not doing it wrong, just doing what we have to in order to make it work.
SashaFierce
05-19-2017, 06:32 PM
Tillmen, would you consider locking down the prime mapdb to authorized map cartographers?
People keep doing dumb things and breaking stuff.
LostRanger
05-23-2017, 02:44 PM
If that's done, I'd like to be an authorized cartographer (I author under LostRanger). I tend to cleanup minor things when I notice them
Some of my recent contributions:
Mapping up to Dragonspine Fane in ZL, including the custom StringProcs needed to deal with RT. (It'd be handy if there was some flag that said 'wait for roundtime' so stringprocs weren't needed) (;mapmap didn't handle the staircases correctly)
A couple Narost corrections where rooms were not indicated on the map.
Mapping out most tables at Firefly Villa (FWI) (couldn't do all of them since some were in use by AFK people who wouldn't invite), all tables at The Watering Hole (FWI) including tagging that location as 'table', some tables at Frith's (I think), and all tables at wherever ;go2 table in Solhaven takes you. (I'm debating on writing a script to do these procedurally, though ;mapnav has been a lifesaver for it)
That said, I think restricting Mapmap contributors is ultimately harmful (I'd never have started dabbling with it if I had to go through some approval process instead of simply being careful). In a perfect world, I'd rather see a system where some people could commit maps at the same access we have now -- and new contributors could have a way to contribute changes that goes through some sort of moderator queue.
SashaFierce
05-23-2017, 02:47 PM
The problem is every Tom, Dick and Harry thinks they know how to make changes, and then they fuck things up.
As evidenced by TV to WL breaking and looping through the short cut, and multiple other situations.
LostRanger
05-23-2017, 06:31 PM
The problem is every Tom, Dick and Harry thinks they know how to make changes, and then they fuck things up.
As evidenced by TV to WL breaking and looping through the short cut, and multiple other situations.
Yes. I'm familiar with (and have been painfully annoyed by....) the TV->WL route having broken multiple times.
Which is why I'd love a way for mapdb contributions to work somehow like how open source projects manage contributions
There's a trusted team of contributors who can commit changes to the 'master'
Anybody else can submit contributions, but someone in the first group has to look them over and accept them before they're formally accepted into the master mapdb that everyone downloads.
You become a member of the first group after a history of good contributions via the second.
Of course, that'd require a lot of changes that are only debatably worth the time investment. (For instance, I don't think there's any notion of incremental changes to the mapdb -- though it'd be entirely possible to compare two copies and make such a diff)
Legales
06-06-2017, 12:36 PM
Tillmen, would you consider locking down the prime mapdb to authorized map cartographers?
People keep doing dumb things and breaking stuff.
I should keep my mouth shut, but I really wanted to voice my opposition because I hope the database is never locked. Follow Google's motto: don't be evil.
It's worked for over 7 years this way, why change it. Yes, I also get annoyed when people make dumb changes, but I think there are enough experienced and vigilant people that help fix it quickly and teach others. Here are some other points:
1. Who decides who can edit and who can't? Tillmen already approves complex string additions to the database before they're uploaded. He's too busy to be an admin for individuals too.
2. What if an experienced programmer returns and can't contribute? Returning players won't know you need to get approved or how to. (LostRanger's return is a great example). Also new maps might not be made and uploaded because of lockout rules.
3. People feel like they're contributing to the game and that's a good thing. They can start to learn some ruby and the community on this forum and in LNet's code chatroom can help them. (TG01/Dreaven didn't even know how to write ruby code before GS4)
4. Finally how often are rooms breaking? True, it happens but it's not a daily thing. Should a disaster happen, Tillmen has server logs and backups. Most of Elanthia is mapped so comprehensive updates aren't required too often. The entire community is what 400-500 players? A fraction of this will even attempt to map. Let's not stifle it's growth by restricting our small community.
Ok, I've said my part. I'll step off my soapbox and shut up now.
Fortybox
06-07-2017, 02:24 AM
I want to cut whoever messed up ;go2 in WL.
Legales
06-07-2017, 10:16 AM
I want to cut whoever messed up ;go2 in WL.
What happened and where? I can login later today and take a look.
Taernath
06-07-2017, 05:46 PM
What happened and where? I can login later today and take a look.
I don't know what the specific issue is, but activating ;go2 in IMT to a room in the Landing takes me to an unmarked room in Kazalia's outfitting.
*edit* There is, apparently, a brand new IMT-WL trail map in the db that has no matching rooms on it.
Legales
06-07-2017, 06:25 PM
I don't know what the specific issue is, but activating ;go2 in IMT to a room in the Landing takes me to an unmarked room in Kazalia's outfitting.
*edit* There is, apparently, a brand new IMT-WL trail map in the db that has no matching rooms on it.
I'm not sure if someone started adding things for this new IMT map and didn't finish or accidently broke go2? Either way, I went in and fixed it and all seems to be working.
Taernath
06-07-2017, 07:20 PM
Yep, seems to be working, thanks.
Beniah
06-08-2017, 02:24 PM
I'm not sure if someone started adding things for this new IMT map and didn't finish or accidently broke go2? Either way, I went in and fixed it and all seems to be working.
Awesome thanks! Thought it was just on my end.
Powered by vBulletin® Version 4.2.5 Copyright © 2025 vBulletin Solutions Inc. All rights reserved.