PDA

View Full Version : ForgeMaster



Dintarl
04-14-2016, 04:43 PM
I just finished condensing all of my old StormFront scripts for the Forging disciplines into a single lich script, ForgeMaster, which is now available on the repository.

It should run in any town, and will continuously run until all of the selected disciplines are at 500.

In case you are starting fresh, there is also options to make either a regular or a perfect forging hammer. If selected, the hammer loop will run after your forging: crafting is finished.

To get started, once you have the script downloaded, just enter ";ForgeMaster setup" - you will be able to select which disciplines you want to master, and will need to fill in each of the fields below (they come with instructions, just mouse-over.)

I know I shouldn't have to say this, but please do not run the script while AFK.

I hope this script makes the road to mastery a little bit less painful!

Also, a big thank you to SpiffyJr for the code I cannibalized to make this script's GUI.

SylphSorc
04-14-2016, 04:56 PM
Awesome, I will try it out soon.

Tgo01
04-14-2016, 05:13 PM
Very nice.

kutter
04-16-2016, 09:36 PM
Well just tried it and this is what I am seeing:

>
[ForgeMaster]>go workshop
Realizing you still have some time remaining, the clerk directs you to your rented workshop.

[Diamond Workshop - ]
Fashioned of dark granite, the smoothly finished walls in this room form a fitting backdrop for the devices the elven masters have constructed to aid them in their work. Along one wall stands a low workbench with rows of tool racks against the wall behind it. Evenly spaced about the room are a grinder, a polisher and a vise, the base of each inlaid with tiny diamonds. You also see a polished brass door, a wooden bin and a rental hourglass.
Obvious exits: out
[ForgeMaster]>take bar from my cloak
>
Get what?
>
[ForgeMaster]>go door
[Diamond Forge - ]
A large, black iron anvil stands in the center of this chamber. Within easy reach to either side of the anvil are a brick forge and a tempering trough. Directly above the trough, suspended by a web of delicate, mithril chains, hangs a teardrop-cut crystal easily the size of a giantman. One corner of the room is taken up by a low-walled cistern inlaid with scores of tiny diamonds, and a leather bucket hangs from a hook on the wall next to it. Heat from the brick forge fills the chamber. Some discarded oilskins rest haphazardly in the corner. You also see a polished brass door.
Obvious exits: none
>
[ForgeMaster]>take head-glyph from my cloak
You remove a wax cudgel head-glyph from in your leather cloak.
>
[ForgeMaster]>take bar from my backpack
You remove a scribed bronze bar from in your sailcloth backpack.
>
[ForgeMaster]>artisan skill
In the skill of forging - crafting, you are a master with 500 ranks.
In the skill of forging - one handed edged, you are a master with 500 ranks.
In the skill of forging - one handed blunt, you are a highly skilled laborer with 443 ranks.
In the skill of forging - two handed weapons, you are a master with 500 ranks.
In the skill of forging - pole arms, you are a master with 500 ranks.
>
[ForgeMaster]>think
You rub your chin thoughtfully.
>
[ForgeMaster]>glance
You glance down to see a wax cudgel head-glyph in your right hand and a scribed bronze bar in your left hand.
>
[ForgeMaster]>stare head-glyph
You carefully trace the wax cudgel pattern onto the surface of the bronze in your hand.

Your material is marked with a pattern, next you'll need to shape it somehow.
Glancing around you see a trough and a pair of tongs.
Roundtime: 30 sec.
R>
--- label error: `BGLYPH4' was not found, and no `LabelError' label was found!
C:/Users/J/Desktop/lich/lich.rbw:4339:in `goto'
--- Lich: ForgeMaster has exited.

Dintarl
04-17-2016, 10:22 AM
Sorry about that - I had "BLYPH4" as the label instead of "BGLYPH4" - the corrected version is up on the repo now.

Erous
05-21-2016, 01:47 AM
Sorry for the bump on this but wanted to raise an issue that attempting to use it the script just seems to stall after the oak block is taken from my container. Trying several other scripts, they all seem to behave the same way. Do the forging scripts seem to not work any longer or is there a behavior change that's preventing this from working? Thanks:

[ForgeMaster]>open my package
You open a plainly wrapped package.
>
[ForgeMaster]>empty my package in my greatcloak
You try to empty the contents of your package into your greatcloak, and everything falls in quite nicely.
Roundtime: 3 sec.
R>
[ForgeMaster]>throw my package
You throw away your package.
>
[ForgeMaster]>go workshop
Realizing you still have some time remaining, the clerk directs you to your rented workshop.

>
You grab an oak block from one of the large pouches lining the inside of your traveler's greatcloak.

That's it...stops right there with no further action. This is when starting to create the forging hammer

Hazado
05-21-2016, 10:37 AM
Probably not accounting for the special message your cloak has when removing items.


Sent from my iPhone using Tapatalk

Erous
05-21-2016, 10:44 AM
Probably not accounting for the special message your cloak has when removing items.



Well...that's unfortunate..

Edit: You were right, climatewear scripts don't seem to play nice with any forging script

Viekn
05-21-2016, 11:33 AM
Well...that's unfortunate..

Edit: You were right, climatewear scripts don't seem to play nice with any forging script

I've had issues also in the past with climarewear messaging and Sloot trying to stow items.

Dintarl
05-21-2016, 04:14 PM
The newest version of ForgeMaster is up and *should* play well with ClimateWear scripts now. If there are any issues still, please let me know and I'll get it updated ASAP.

Erous
05-21-2016, 04:27 PM
The newest version of ForgeMaster is up and *should* play well with ClimateWear scripts now. If there are any issues still, please let me know and I'll get it updated ASAP.

You sir, or madam are a genius and a scholar

Erous
05-22-2016, 12:18 PM
Looks like I'm getting hung up again, somewhere with the slab cutter:

[ForgeMaster]>take bar from my greatcloak
>
You grab a bronze bar from one of the small pouches lining the inside of your traveler's greatcloak.
>
[ForgeMaster]>swap
You swap your bronze bar from your right to your left hand.
>
[ForgeMaster]>poke slab

You've just set the slab-cutter to cut your bronze bar into a 1lb. piece and a 2lb. piece. If that's where you want it, go ahead and PULL slab-cutter.

Pauses here and doesn't continue.

Edit: Looks like it has to do with the main forging bag. I had it set to the scripted greatcloak, then swapped them around to where my satchel is the main bag and we're rolling again. May be due to the script.

Also this part got hung up to:

[ForgeMaster]>remove my forging-hammer
Remove what?

I think it's assuming Im wearing the hammer eventhough I wasnt

Dintarl
05-22-2016, 12:25 PM
The script is pretty much built around wearing the forging hammer. I could modify it to use the main forge bag, but that would take a while.

The slab looks like you grabbed an already-cut slab. Main bag and cut bag need to be different.

Dintarl
05-22-2016, 01:42 PM
Made a couple small updates to make cutting run a bit smoother, and blunt waste less material.

Dintarl
05-22-2016, 02:11 PM
Newest version now up - has an option to store your forging hammer. This uses the main forge bag - I'm not adding another variable to stick it in another container.

If you leave it unchecked, the script will continue to wear the hammer instead.

Gnomad
05-22-2016, 02:29 PM
Well...that's unfortunate..

Edit: You were right, climatewear scripts don't seem to play nice with any forging script
You tried it with Forgery? Can you post a log in my thread so I can fix it?

Erous
05-22-2016, 03:34 PM
You tried it with Forgery? Can you post a log in my thread so I can fix it?

I did...I tried forgery, forge loop, forge perfects and dforge and ran into the same problem. I can try forgery again later, right now running with forgemaster so I'll give it a go

Erous
05-22-2016, 03:37 PM
Newest version now up - has an option to store your forging hammer. This uses the main forge bag - I'm not adding another variable to stick it in another container.

If you leave it unchecked, the script will continue to wear the hammer instead.

super, thanks much!

Erous
05-23-2016, 10:08 AM
Didn't have a chance to look at forgery yet again, but I still have some time to go for a perfect forging hammer so I'll hopefully get to it today

Erous
05-24-2016, 08:47 AM
Another update. The script is stopping without making a perfect forging hammer based on the response from the forge process, rather than checking the hammer. Example: 'You finish your work and step back, turning the mithril forging-hammer in your hands. You smile as you realize that this piece is probably the best that you can create."

>glance
You glance down to see a well-crafted oak-handled mithril forging-hammer in your right hand and nothing in your left hand.

Dintarl
05-26-2016, 11:25 AM
A few questions for this scenario, because it just ran perfectly for me twice:

Did you have 500 Crafting?

Did you have non-superior hammer head/handle pieces in your inventory when you started it?

If your answers are yes and no respectively, please send me a full log of the vise attempt, including the container you're pulling the pieces from.

Also - your main forge bag and cutter bag are different, yes?

Erous
05-26-2016, 01:25 PM
Did you have 500 Crafting?
No

Did you have non-superior hammer head/handle pieces in your inventory when you started it?
No


Also - your main forge bag and cutter bag are different, yes?
Yes

Dintarl
05-26-2016, 02:04 PM
Did you have 500 Crafting?
No


This is why. It is impossible to make a perfect hammer with less than 500 crafting.

Erous
05-26-2016, 04:51 PM
Aha. Got it...but, isn't that the purpose of the checkbox on Forgemaster that has you select whether or not you should continue making hammers till perfect? Or maybe that's my misconception of what that button does. Because if I were to just select make hammer, I would just make a hammer.

Dintarl
05-26-2016, 06:41 PM
That button is there for the person who has 500 points and wants a perfect hammer so they can start working on making perfects. If you're just looking to level up your forging subskills, the other one works just fine.

I have it checked on mine when I'm working crafting, but it will not fire off unless crafting finishes, and crafting won't stop until my crafting is 500.

It is possible to have crafting, perfect hammer, and at least one subskill all checked, and have the script finish up crafting, make a perfect, and go straight into the subs.

Itachi
06-05-2016, 10:53 PM
It's throwing out my perfect handles when trying to attempt to make a perfect hammer.

Dintarl
06-06-2016, 06:09 PM
Looking through the code, I can't see why it would do that: if you get the "you smile as you realize" message, it should dump the block in the trash, polish the handle, and put it in your cut bars bag.

If you're getting the "satisfied with the piece" message, then it should be throwing the handle out.

Do you have a cut bars bag set up?

Itachi
06-09-2016, 05:20 AM
Once I turned ;surge off it started working properly. Like we discussed via email, it is possible that the recasting surge after an attempt was creating the hangup which then kicked it into trash mode. Either that or the reboot, whichever it was it is cleared up now. Thank you for the wonderful script and support!

Dintarl
06-09-2016, 09:24 AM
I'll look into updating the code a bit to take the grinder bit from one set of matches to two, so that getting a '...wait' message while grinding doesn't cause this issue any more.

Dintarl
06-09-2016, 09:33 AM
New version up - getting the '...wait' message while the grinder is active will no longer cause it to think the grind failed due to roundtime, then fail to grind due to having a hammer-handle or hammer-head in your hand and toss the piece regardless of quality.

I only did this for the hammer/perfect hammer sections; the skill up sections don't matter if it goes into that sequence, as the piece is getting trashed anyway.

Erous
06-14-2016, 01:01 AM
You've been helpful responding to and answering concerns for the script, thanks for that and because of that this is my forging script of choice, now I have another issue. Looks like when forging outside of the forging hammer, the script is getting hung when the bronze bar gets to small. Here's the snippet:

>You finish this round of work on your bronze bar and set the tongs on the anvil, realizing that there's more work to be done before the bronze bar will resemble its intended form.

[ForgeMaster]>go door
...wait 1 seconds.
R>
[ForgeMaster]>go door

[ForgeMaster]>put my bar in barrel
>
As you place a hammered bronze bar into a wooden barrel you feel pleased with yourself at having cleaned up the surrounding area.
>
[ForgeMaster]>put my head-glyph in my greatcloak
I could not find what you were referring to.


Edit: Another snippet - -

[ForgeMaster]>glance
You glance down to see a wax spear head-glyph in your right hand and a flattened bronze bar in your left hand.
>
[ForgeMaster]>stare head-glyph
You begin to trace the pattern of the wax spear head-glyph onto the surface of the bronze. Before the design is complete you reach an edge of the bar and realize it is too small.

Roundtime: 5 sec.
R>
[ForgeMaster]>go door

[ForgeMaster]>put my bar in barrel
As you place a flattened bronze bar into a wooden barrel you feel pleased with yourself at having cleaned up the surrounding area.
>
[ForgeMaster]>put my head-glyph in my greatcloak
You tuck the wax spear head-glyph into a large pocket inside of your traveler's greatcloak.

It stops here. Forgemaster is still running but no further actions being taken

Dintarl
06-14-2016, 11:05 PM
Was there something missing from the first snippet? Not sure how it could have gone from more work being done to the toosmall label.

Also not sure how it could have gone there without a glyph in hand to get the "I could not find" message.

What type of scripts are on the cloak in the second snippet? I added in "You place ..." for Climatewear, but haven't seen the "You tuck the ..." message.

If you happen to have more for the first snippet, I would like to look into what happened there a little more closely, because it should never be possible for the script to go trash a too small slab without a glyph in hand; the label can only be reached from the point where you're staring at a glyph, and only if you get the message about the bar being too small...so I'm very curious.

Edit: just uploaded a version that will get along with whatever scripts you have on your greatcloak.

Erous
06-14-2016, 11:35 PM
Thanks! I didn't save the snippet, but I'll give it another run and post details again if it hangds

Erous
06-15-2016, 09:21 AM
Whatever you did in the latest released fixed any problem I had. Thanks for the help

Dintarl
06-27-2016, 01:00 PM
Uploaded an update that should allow ForgeMaster to catch the mastery rank 100% of the time. This does, unfortunately, add a tiny bit more scroll on certain artisan skill checks, and will require user input for the very first rank in each skill.

Dintarl
07-01-2016, 09:32 AM
Another small update made this morning with a few more tweaks and adjustments.

Dintarl
07-10-2016, 11:56 AM
Couple of small updates: ensures all bags are open at the start and slowed down the cutter process ever so slightly to prevent it from getting hung up after moving too quickly and trying to put a non-existent game object away.

Gnomad
07-10-2016, 12:39 PM
Couple of small updates: ensures all bags are open at the start and slowed down the cutter process ever so slightly to prevent it from getting hung up after moving too quickly and trying to put a non-existent game object away.please stop updating, you're making me look bad for ignoring forgery to get grad work done

thanks

Dintarl
07-13-2016, 12:23 PM
Sorry! I'm running another character through with this and adjusting/fixing all the little things I find.

Grad work is way more important, though. If I were still in grad school, these wouldn't be getting done either!

Dintarl
07-18-2016, 09:50 AM
Another quick update. Managed to break a label in one not long ago, just fixed it. OHE should be working appropriately again.

peam
07-19-2016, 10:44 PM
It worked perfectly to get my character mastered in Crafting, but it's hanging up when I attempt to start working on actually forging THW, specifically at the part where it cuts bronze bars.


You pull down on the lever and neatly cut your bronze bar in two! Releasing the lever, you pick up the second piece with your right hand.

>[ForgeMaster]>put my bar in my backpack
You put a bronze bar in your diamond-clasped backpack.
>[ForgeMaster]>put my bar in my backpack
>You put a bronze bar in your diamond-clasped backpack.
>[ForgeMaster]>take bar from my backpack
You remove a bronze bar from in your diamond-clasped backpack.
>[ForgeMaster]>swap
You swap your bronze bar from your right to your left hand.
>[ForgeMaster]>poke slab

You've just set the slab-cutter to cut your bronze bar into a 1lb. piece and a 2lb. piece. If that's where you want it, go ahead and PULL slab-cutter.

This is the line it's gotten hung up on 5+ times.

Dintarl
07-22-2016, 10:51 AM
Based on what I can see here, the only thing I can think of that might be causing this is that you have your Main Forge Bag and Cut Bars Bag set to the same bag. It pulls the bars that it hasn't finished cutting from the Main bag and puts the ones that are finished (in the case of THW, 3 pounds) in the Cut Bars Bag. If they're the same, you'll end up trying to cut the finished ones and it will hang.

If this is not the case, please see the PM I sent you and get me an email of the log so I can see exactly what is happening.

Thank you!

droit
07-22-2016, 03:14 PM
Thanks for this script, btw. It has motivated me to finally master crafting.

Jcitalia4
08-14-2016, 11:41 AM
Script is brilliant. Decided to bite the bullet and forge as a warmage (yay penalties). Any chance of adding a function where it keeps celerity/haste up at all?

Jcitalia4
09-27-2016, 06:53 AM
At 499 crafting ranks now and was wondering, will it make a mithril perfect hammer to work magic metals or just a regular perfect hammer?

Dintarl
09-29-2016, 07:49 PM
Once you hit 500, if you have the "make a perfect hammer" box selected, it will use mithril to create your perfect hammer.

It will make one superior head, one superior handle and then attempt to turn them into a perfect hammer. If the vise does not return a perfect hammer, it will start the perfect hammer creation process from scratch.

Mnute
10-03-2016, 10:16 PM
Once you hit 500, if you have the "make a perfect hammer" box selected, it will use mithril to create your perfect hammer.

It will make one superior head, one superior handle and then attempt to turn them into a perfect hammer. If the vise does not return a perfect hammer, it will start the perfect hammer creation process from scratch.

Is there any setting to save up a bunch of superior pieces so that one may use "gift" to have a better chance to make a perfect?

Dintarl
10-05-2016, 12:23 AM
It does not, because there are other options out there which do exactly that already. If you want to go that route, I would suggest the fixed version of forge-perfects. It will allow you to create as many heads and handles as you would like and then combine them when you're done. The hammer setting om ForgeMaster is just there for convenience.

Mnute
10-05-2016, 12:44 PM
It does not, because there are other options out there which do exactly that already. If you want to go that route, I would suggest the fixed version of forge-perfects. It will allow you to create as many heads and handles as you would like and then combine them when you're done. The hammer setting om ForgeMaster is just there for convenience.

Thank you for the info.

Dintarl
10-19-2016, 12:32 PM
Added the EG forging aprons to the apron checks. The script will now function with these.

Dintarl
01-03-2017, 12:36 PM
Quick update to fix issues with hanging up between mastering one skill and starting the next.

Tuxedo Gin
01-04-2017, 03:56 PM
An extremely minor thing, but if you're still doing fixes, there's a hang when buying materials if you're wearing a pack of any kind, because the script tries to target your pack instead of opening/emptying the package of purchases.

Dintarl
01-05-2017, 10:57 AM
For now, you'll need to enter the pack descriptor in the field with "pack" - so if it is a golden leather pack, it will likely either be "golden pack" or "leather pack" that you will need to enter. Can find out which works by trying TAP with each.

I'm working on a full-scale rewrite to de-StormFront this right now, and once that is done, I'll remove the pack step completely so it will no longer be needed.

Tuxedo Gin
01-05-2017, 03:18 PM
That didn't seem to work for some reason when I initially ran into problems awhile ago, so I just switched out the pack for something else, just thought it was worth mentioning.

Topher1
02-07-2017, 05:17 PM
elp

SonoftheNorth
02-07-2017, 05:23 PM
If this is your first skill point in this skill, enter the THINK command to continue.

Topher1
02-07-2017, 06:50 PM
Thank you.

Scisco
04-07-2017, 11:58 PM
Is there a way to set the scrip to just make a particular weapon and keep all the perfect ones? For example, to set it to take the metal I have in one bag and made a broadsword (or whatever I specify) over and over until all the metal in the bag is gone.

SonoftheNorth
04-08-2017, 12:27 AM
Is there a way to set the scrip to just make a particular weapon and keep all the perfect ones? For example, to set it to take the metal I have in one bag and made a broadsword (or whatever I specify) over and over until all the metal in the bag is gone.

Forgery does that but it doesn't combine the perfect pieces, you do that yourself and that's the fun part.

Eoghain
05-07-2017, 09:17 PM
Anyone know how to keep this script from immediately hanging because no backpack in all of Elanthia can contain the shit it tries to buy upfront?

Dintarl
08-01-2017, 03:56 PM
I've never had a problem with this hanging due to excessive purchasing when the variables are set correctly.

The containers listed in the setup GUI CANNOT be the same. It will hang 100% of the time if you try to set them all to the same container.

That said, I am still in the process of re-writing this script to make it substantially more efficient.

Jahadeem
09-14-2019, 04:44 PM
I believe something may have changed in the wording when doing (at least) OHE.
I am using the newest version last udpated 01/03/2017 but it dies when dealing with checking into cutting up bronze bars.

Bearalpha81
12-02-2022, 06:29 PM
I believe something may have changed in the wording when doing (at least) OHE.
I am using the newest version last udpated 01/03/2017 but it dies when dealing with checking into cutting up bronze bars.

I know this is an old thread but has anyone had the following hang issue[ForgeMaster]>take bar from my back
>
You remove a bronze bar from in your heavy backpack.
>
[ForgeMaster]>swap
You swap your bronze bar from your right to your left hand.
>
[ForgeMaster]>poke slab

You've just set the slab-cutter to cut your bronze bar into a 1lb. piece and a 2lb. piece. If that's where you want it, go ahead and PULL slab-cutter.

>